-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masonry layout manager and provider #526
base: master
Are you sure you want to change the base?
Conversation
Added columnIdx prop on Layout.
I use it by copy it to my code, but it work little strangely when load more data, it overlap the pre data. |
@dwidc I find the reason. When call dataProvider.cloneWithRows method and not set firstModifiedIndex param, your relayoutFromIndex method will go wrong because the startIndex is not zero. |
@Paul0523 I never set |
how to include this pr to my react native project |
Please merge/add masonry layout to this library! It would be the best thing ever 'cause there are no libraries that support infinite scroll + recycling + masonry! |
when using with infinite scroll, picture can't be added? |
Bug found, |
@dwidc any updates on this PR? also, can you provide us a demo to show How to use this new provider? Thank you very much! |
@lclrobert2020 any update? |
I made it work a few months ago, but I forget where did I put my code, |
@lclrobert2020 Thank you so much! |
https://snack.expo.dev/@robertli93/grid_example this is my expo snack I have uploaded a working masonrylayoutmanager to the npm but I didn't have time to write readme, this masonrylayoutmanager is a fixed version of other people's work ( sorry i forget who and where is the original) so credit should also give to them there are some minor problems with the snack e.g. using UNSAFE_componentWillMount, I will write a better one if I had time |
Thanks for sharing. Btw, does it support the responsive layout? I mean: on the screen-width resize how to change & redraw the item columns? |
Why is it not merged yet ?? |
MasonryFlashList will meet your needs Use High performance mode, have a look at Shopify/flash-list#946 (comment) |
Added staggered grid / masonry layout.
I made this as #175 has no follow-ups.
Currently only support vertical orientation, horizontal layout is not yet implemented.